Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes regression bug due to ERA Tablespace workaround #342

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Fixes regression bug due to ERA Tablespace workaround #342

merged 2 commits into from
Jan 12, 2024

Conversation

SandyRogers
Copy link
Member

This PR:

  • fixes the ability for the mgnify-web Taskfile task to automatically create a text DB fixture.
  • the inability to do so was a regression bug, introduced by a workaround needed for the ERA tablespace on ENA's Oracle DB, which recently stopped routing Views automatically to the default tablespace. Unforunately, SQlite doesn't support . in table names, or tablespaces, so our "fake" ENA database can't perfectly match ERA. This adds a workaround for that.

@SandyRogers SandyRogers requested a review from MGS-sails January 3, 2024 17:09
@SandyRogers SandyRogers self-assigned this Jan 3, 2024
@SandyRogers SandyRogers merged commit 808dab4 into develop Jan 12, 2024
4 checks passed
@SandyRogers SandyRogers deleted the update-test-db-fixtures branch January 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGS-sails MGS-sails MGS-sails approved these changes

Assignees

@SandyRogers SandyRogers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SandyRogers @MGS-sails