Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EBI Search dump and add tests #352

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix EBI Search dump and add tests #352

merged 1 commit into from
May 2, 2024
+54 −6

Conversation

SandyRogers
Copy link
Member

@SandyRogers SandyRogers commented Mar 12, 2024 •
edited
Loading

This PR:

  • fixes some regression bugs with EBI Search dump commands, following refactoring for metagenomics exchange submission which changed some attribute names
  • adds some simple end-to-end tests for the EBI Search dump commands, since no tests caught this earlier
  • moves the metagenomics exchange tests to a more generically named test folder for these things

@SandyRogers
fixes regression bug with EBI Search dump commands, following refacto…
429e8be 
…ring for metagenomics exchange. also adds some simple e2e tests for ebisearch dump commands.
@SandyRogers SandyRogers changed the base branch from master to develop March 12, 2024 13:30
@SandyRogers SandyRogers requested a review from mberacochea March 12, 2024 13:31
@SandyRogers SandyRogers merged commit 1f2ec72 into develop May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mberacochea mberacochea Awaiting requested review from mberacochea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SandyRogers