Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/run accession for assembly #372

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Bugfix/run accession for assembly #372

merged 2 commits into from
Mar 7, 2025

Conversation

SandyRogers
Copy link
Member

Handle cases where an assembly has run name metadata like ABC_SRR1234567; i.e. a valid run accession exists but in an unexpected form.

@SandyRogers
fixes retrieval of run accession for assemblies
b0d388a 
(where run name metadata has a prefix)
mberacochea
mberacochea approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@mberacochea mberacochea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sandy!

@SandyRogers SandyRogers changed the base branch from master to develop March 7, 2025 11:10
@SandyRogers SandyRogers merged commit d59e72b into develop Mar 7, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mberacochea mberacochea mberacochea approved these changes

@Vkale1 Vkale1 Awaiting requested review from Vkale1

@chrisAta chrisAta Awaiting requested review from chrisAta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SandyRogers @mberacochea