Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda documentation #408

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

apriltuesday
Copy link
Contributor

No description provided.

@apriltuesday apriltuesday marked this pull request as ready for review January 2, 2024 11:05
@apriltuesday apriltuesday self-assigned this Jan 2, 2024
Comment on lines +65 to +66
Note that with conda installation you can't invoke the pipelines directly via Nextflow, so you will need to use the corresponding `cmat` commands - e.g. `cmat annotate` instead of `nextflow run annotation_pipeline.nf`.
All the same command line options apply.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this our main mode of executing CMAT ?
It sounds more elegant and easier to document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you mean just here in the readme, yes probably, I was just being lazy... I'll update.

I think it would also work for our OT submissions, I wanted to try getting the commands to work outside of the conda install but we could honestly even just use the conda version on our cluster...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there somewhere the full list of corresponding cmat commands to use with conda?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created #409 for generalising the wrapper script (and hence the short cmat commands), for now as you've suggested I've just included the corresponding cmat commands in the readme.

Comment on lines +22 to +32
- biopython ==1.77
- coverage ==6.5.0
- coveralls ==3.3.1
- jsonschema ==3.2.0
- numpy ==1.24.3
- pandas ==1.5.3
- pytest ==7.2.2
- pytest-cov ==2.10.0
- requests ==2.31.0
- requests-mock ==1.8.0
- retry ==0.9.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this some formatting standard I do not know about or an error ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a formatting standard that I also did not know about, bioconda utils lint picked it up in the PR.

Copy link
Collaborator

@M-casado M-casado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a small comment

Comment on lines +65 to +66
Note that with conda installation you can't invoke the pipelines directly via Nextflow, so you will need to use the corresponding `cmat` commands - e.g. `cmat annotate` instead of `nextflow run annotation_pipeline.nf`.
All the same command line options apply.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there somewhere the full list of corresponding cmat commands to use with conda?

@apriltuesday apriltuesday merged commit 76e4294 into EBIvariation:master Jan 9, 2024
1 check passed
@apriltuesday apriltuesday deleted the conda-doc branch January 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants