Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3588 update footer with links to Licensing and Long-term data preservation #207

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

nitin-ebi
Copy link
Contributor

@nitin-ebi nitin-ebi commented Jun 4, 2024

Changes deployed in dev : https://wwwdev.ebi.ac.uk/eva/EVA-3588/
image

@nitin-ebi nitin-ebi self-assigned this Jun 4, 2024
@nitin-ebi nitin-ebi requested review from tcezard and apriltuesday June 4, 2024 12:14
@@ -0,0 +1,65 @@
/**
* Copyright (c) EMBL-EBI 2015
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*/
* This file is a copy of foot.js from EBI-Framework V1.1 (https://github.com/ebiwd/EBI-Framework/blob/v1.1/js/foot.js)
* (Commit - https://github.com/ebiwd/EBI-Framework/tree/17a235abb0d2c14493752b248afa23c83de48aca)
* This is a workaround for adding couple of links in the footer (Services section) which are not present in EBI-Framework V1.1
* When updating the website, make sure to remove this and use the footer code provided by the EBI-Framework
*/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Contributor

@apriltuesday apriltuesday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nitin-ebi nitin-ebi merged commit f035d02 into EBIvariation:master Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants