Add MPI option to AXL #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a refactoring step to migrate the MPI AXL wrapper implementation out of SCR and in to AXL. MPI will only be enabled when AXL is compiled with -DMPI=ON (MPI=OFF by default).
adammoody
reviewed
Apr 1, 2022
Co-authored-by: Adam Moody <[email protected]>
|
Thanks, @mcfadden8 . This looks good to me. Ready for merge? |
|
Yes I am ready to merge. We also need to merge LLNL/scr#501 at the same time since it depends upon these changes being in place. (will likely have build problems if both are not merged in concert with one another). |
|
On second thought, let's wait until we are completely ready to merge LLNL/scr#501 and then do them both at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring step to migrate the MPI AXL wrapper
implementation out of SCR and in to AXL. MPI will only be enabled
when AXL is compiled with -DMPI=ON (MPI=OFF by default).
There is no intended change in function with this refactoring. The axl_mpi wrapper API functions that were previously in SCR have been moved to this library.
This relates to #489
This also relates to the SCR PR here: LLNL/scr#501