Re-enable jenkins HIP CI #735
Conversation
streeve
force-pushed
the
enable_jenkins_hip
branch
from
8ccf5b8 to
462d0c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
======================================
Coverage 96.4% 96.4%
======================================
Files 92 92
Lines 14763 14763
======================================
Hits 14240 14240
Misses 523 523 ☔ View full report in Codecov by Sentry. |
docker/Dockerfile.hipcc
Outdated
| @@ -100,7 +100,7 @@ RUN ARBORX_VERSION=4834bff44c23c9510c6ed93366638dcdf85ab217 && \ | |||
| -D CMAKE_INSTALL_PREFIX=${ARBORX_DIR} \ | |||
| -D CMAKE_BUILD_TYPE=Debug \ | |||
| -D CMAKE_CXX_COMPILER=hipcc \ | |||
| -D CMAKE_CXX_FLAGS=-amdgpu-target=gfx906 \ | |||
| -D CMAKE_CXX_FLAGS=-amdgpu-target=gfx908 \ | |||
There was a problem hiding this comment.
Wait why do we add flags here?
There was a problem hiding this comment.
Looks like we've had that since we added TPL to HIP builds. All the jenkins builds need version/option updates - are you okay if I do that separately?
There was a problem hiding this comment.
Sure. You might want (whenever you handle this) to pass -D GPU_TARGETS=gfx908.
This is intended for rocThrust, making sure that it does not make you compile for all AMD GPU architectures that cmake knows about.
streeve
force-pushed
the
enable_jenkins_hip
branch
from
1f0a446 to
462d0c2
Compare
|
retest this please. |
streeve
force-pushed
the
enable_jenkins_hip
branch
from
462d0c2 to
fa2ad96
Compare
|
retest this please. |
1 similar comment
|
retest this please. |
streeve
force-pushed
the
enable_jenkins_hip
branch
3 times, most recently
from
650fbba to
0889695
Compare
streeve
force-pushed
the
enable_jenkins_hip
branch
from
0889695 to
988b1cf
Compare
streeve
force-pushed
the
enable_jenkins_hip
branch
from
988b1cf to
1673b24
Compare
No description provided.