Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI with fedora latest #804

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

streeve
Copy link
Member

@streeve streeve commented Feb 4, 2025

Previous issues with MPI prompted move to rawhide; issues noted in #803 with gtest caused unrelated failures

@streeve
Copy link
Member Author

streeve commented Feb 4, 2025

@aprokop this will fix the issue in your PR. I'm fine to merge and fix the docker build separately

@streeve streeve requested a review from lebuller February 4, 2025 17:44
@aprokop
Copy link
Collaborator

aprokop commented Feb 4, 2025

For some reason, there are still pending fedora:rawhide checks.

@junghans
Copy link
Member

junghans commented Feb 4, 2025

The cabana CI containers depend on the kokkos ci containers, but they haven't been updated for a while due to kokkos/ci-containers#56. So I believe fedora:latest is still F40 not F41 (previous rawhide).

@streeve
Copy link
Member Author

streeve commented Feb 5, 2025

The cabana CI containers depend on the kokkos ci containers, but they haven't been updated for a while due to kokkos/ci-containers#56. So I believe fedora:latest is still F40 not F41 (previous rawhide).

Good to know - based on the comment in the CI here all I recall is that latest was failing due to MPI. Should we wait if it works now?

@junghans
Copy link
Member

junghans commented Feb 5, 2025

The cabana CI containers depend on the kokkos ci containers, but they haven't been updated for a while due to kokkos/ci-containers#56. So I believe fedora:latest is still F40 not F41 (previous rawhide).

Good to know - based on the comment in the CI here all I recall is that latest was failing due to MPI. Should we wait if it works now?

The kokkos containers got refreshed, I am rebuilding ours right now: https://github.com/ECP-copa/ci-containers/actions/runs/13066871276

@junghans
Copy link
Member

junghans commented Feb 5, 2025

Now there is a hypre issue:

#26 22.37 In file included from /home/kokkos/src/hypre/src/distributed_ls/pilut/DistributedMatrixPilutSolver.h:115,
#26 22.37                  from /home/kokkos/src/hypre/src/distributed_ls/pilut/comm.c:25:
#26 22.37 /home/kokkos/src/hypre/src/distributed_ls/pilut/./struct.h:43:26: error: 'bool' cannot be defined via 'typedef'
#26 22.37    43 |    typedef unsigned char bool;
#26 22.37       |                          ^~~~
#26 22.37 /home/kokkos/src/hypre/src/distributed_ls/pilut/./struct.h:43:26: note: 'bool' is a keyword with '-std=c23' onwards
#26 22.37 /home/kokkos/src/hypre/src/distributed_ls/pilut/./struct.h:43:4: warning: useless type name in empty declaration
#26 22.37    43 |    typedef unsigned char bool;
#26 22.37       |    ^~~~~~~
#26 22.37 gmake[2]: *** [CMakeFiles/HYPRE.dir/build.make:3901: CMakeFiles/HYPRE.dir/distributed_ls/pilut/comm.c.o] Error 1
#26 22.37 gmake[2]: *** Waiting for unfinished jobs....
#26 22.47 gmake[1]: *** [CMakeFiles/Makefile2:542: CMakeFiles/HYPRE.dir/all] Error 2
#26 22.47 gmake: *** [Makefile:136: all] Error 2

I believe this is due to a newer gcc, Is there a problem with bumping hypre to a more recent version.

On a sidenote, starting the Fedora 42 (next release), Fedora's hypre package will be build with CMake, hence we do not need to build it ourselves anymore.

@streeve streeve requested a review from aprokop February 5, 2025 20:01
Copy link
Collaborator

@aprokop aprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@streeve
Copy link
Member Author

streeve commented Feb 5, 2025

I believe this is due to a newer gcc, Is there a problem with bumping hypre to a more recent version.

Maybe I missed something, but I didn't see any updates in their repo fixing that

@junghans
Copy link
Member

junghans commented Feb 5, 2025

I believe this is due to a newer gcc, Is there a problem with bumping hypre to a more recent version.

Maybe I missed something, but I didn't see any updates in their repo fixing that

I guess, we should report it up them then!

@streeve streeve merged commit b7fbc36 into ECP-copa:master Feb 5, 2025
33 checks passed
@streeve streeve deleted the fixup_ci_fedora branch February 5, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants