Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for croplands/pastures (reproduction.f90) #335

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented Oct 14, 2021

It seems the reproduction code was not updated when pastures and croplands were split. This fix now allows for pastures PFTs to reproduce in dist_type = 1, and cropland PFTs to reproduce in dist_type = 8. I believe this addresses the fix on #334 (thanks @mccabete for spotting it).

Description

Collaborators

Motivation and Context

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Testing :

  • All new and existing tests passed.

It seems the reproduction code was not updated when pastures and croplands were split.  This fix now allows for pastures PFTs to reproduce in dist_type = 1, and cropland PFTs to reproduce in dist_type = 8.  I believe this addresses the fix on #334 (thanks @mccabete for spotting it).
@mpaiao mpaiao requested a review from xiangtaoxu October 14, 2021 20:26
@mccabete
Copy link

mccabete commented Oct 15, 2021

@mpaiao
Quick clarification: Does the most recent config.xml also have a <include_pft_pt> flag?

Because my latest config.xml doesn't, only

 <include_pft></include_pft>
  <include_pft_ag></include_pft_ag>
  <include_pft_fp></include_pft_fp>
  

Also, are all grass PFT's part of the pasture scheme by default, or is the pasture scheme a disturbance type, so it needs to be turned on via a disturbance flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants