ED2IN clean up #411
Open
ED2IN clean up #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obal parameters, which should be initialised through XML. Also, variable IPHEN_SCHEME in ED2IN changed meaning, now it only controls whether to use predicted or prescribed phenology for cold deciduous. The leaf phenology strategy of each PFT must be defined through XML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted several variables that used to modify PFT and turbulence parameters from ED2IN.
Description
Several variables in ED2IN modified parameters (mostly PFT parameters), which conflicted with the XML approach of modifying them. The code was streamlined so parameters are now exclusively managed by the XML interface.
Another related change is that
NL%IPHEN_SCHEMEno longer defines the leaf phenology strategy: these now must be set through XML (parameterphenology). Instead,NL%IPHEN_SCHEMEsimply defines whether to use the predicted cold-deciduous phenology (NL%IPHEN_SCHEME = 0) based on Botta et al. (2000), or the prescribed leaf phenology (NL%IPHEN_SCHEME = 1) described in Medvigy et al. (2009).Collaborators
Motivation and Context
This change is long due and reduces confusion between the roles of ED2IN (model approaches and site-specific quantities) and the xml files (PFT-specific or site-independent parameters).
Some turbulence-related parameters (not PFT-specific) required a different approach, because they are defined through namelist when running in coupled mode. In this case, XML still has the last word in ED2, but if they are not set from XML, then the code prioritise the values from RAMSIN over the ED2 defaults.
As a minor change, some non-standard characters in comments were removed from the code, to improve portability to text editors.
Types of changes
Checklist:
Changes to documentation will be applied once the pull request is approved and merged.
Testing :