Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the configuration module #14

Closed
juhtornr opened this issue Jan 2, 2019 · 3 comments
Closed

Update the configuration module #14

juhtornr opened this issue Jan 2, 2019 · 3 comments
Assignees
@silverdaz
Labels
version 2 Task saved for version 2

Comments

@juhtornr
Copy link
Contributor

juhtornr commented Jan 2, 2019

Issue by silverdaz
Monday Dec 10, 2018 at 18:38 GMT
Originally opened as NBISweden/LocalEGA#383

Description

Segregate the configurations to only the container that needs it

Definition of Done

Green PR
@juhtornr juhtornr added this to the Sprint 41 milestone Jan 2, 2019
@juhtornr
Copy link
Contributor Author

juhtornr commented Jan 2, 2019

Comment by juhtornr
Thursday Dec 20, 2018 at 08:15 GMT

@silverdaz Can you elaborate? How it works now, what is the problem and how to fix it?

@silverdaz
Copy link
Contributor

Right now, one file is generated with all the settings, including sensitive information.
A better separation is to create separate specific files for each specific container.
Moreover, you avoid giving credentials to a container that has no business having those credentials.
The code for that is ready, but not merged.

@silverdaz silverdaz added the version 2 Task saved for version 2 label Feb 20, 2019
@silverdaz silverdaz mentioned this issue Dec 11, 2019
Merged
7 tasks
@silverdaz
Copy link
Contributor

Fixed by #87. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silverdaz silverdaz

Labels
version 2 Task saved for version 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juhtornr @silverdaz