Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segregating configurations to their own file per service #87

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Segregating configurations to their own file per service #87

merged 2 commits into from
Dec 11, 2019

Conversation

silverdaz
Copy link
Contributor

@silverdaz silverdaz commented Dec 11, 2019 •
edited
Loading

Each service has only the configurations it needs.
Ingestion for example does not have the master key passphrase.

Moreover, logging is configurable by passing a logger (keyword or filepath) as an environment variable.

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Changes:

  1. split conf.ini into multiple files
  2. updated the logic for loading the logging configuration
  3. added a configure decorator
  4. Code cleanup

Related issues:

#14

@silverdaz silverdaz merged commit 2fe79f0 into master Dec 11, 2019
@silverdaz silverdaz deleted the configuration branch December 11, 2019 06:32
@silverdaz
Copy link
Contributor Author

Fixes #14

@silverdaz silverdaz mentioned this pull request Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@silverdaz