Add hidden id fields to the CV terms form and add a uniqueness clause…

… to the validation
ELIXIR-Belgium · May 31, 2024 · d143bd4 · d143bd4
1 parent 580f342
commit d143bd4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/app/models/sample_controlled_vocab_term.rb b/app/models/sample_controlled_vocab_term.rb
@@ -1,7 +1,7 @@
 class SampleControlledVocabTerm < ApplicationRecord
   belongs_to :sample_controlled_vocab, inverse_of: :sample_controlled_vocab_terms
 
-  validates :label, presence: true, length: { maximum: 500 }
+  validates :label, presence: true, length: { maximum: 500 }, uniqueness: { scope: :sample_controlled_vocab_id }
 
   before_validation :truncate_label
 

diff --git a/app/views/sample_controlled_vocabs/_term_form_row.html.erb b/app/views/sample_controlled_vocabs/_term_form_row.html.erb
@@ -1,5 +1,8 @@
 <tr class="sample-cv-term" data-index="<%= index %>">
-  <td><%= text_field_tag "sample_controlled_vocab[sample_controlled_vocab_terms_attributes][#{index}][label]", term.label  %></td>
+  <td>
+    <%= hidden_field_tag "sample_controlled_vocab[sample_controlled_vocab_terms_attributes][#{index}][id]", term.id %>
+    <%= text_field_tag "sample_controlled_vocab[sample_controlled_vocab_terms_attributes][#{index}][label]", term.label  %>
+  </td>
   <td><%= text_field_tag "sample_controlled_vocab[sample_controlled_vocab_terms_attributes][#{index}][iri]", term.iri  %></td>
   <td><%= text_field_tag "sample_controlled_vocab[sample_controlled_vocab_terms_attributes][#{index}][parent_iri]", term.parent_iri  %></td>
   <td>

diff --git a/app/views/sample_controlled_vocabs/_term_form_row_disabled.html.erb b/app/views/sample_controlled_vocabs/_term_form_row_disabled.html.erb
@@ -8,6 +8,7 @@
 %>
 <tr class="<%= row_class %>" data-index="<%= index %>">
   <td>
+    <%= hidden_field_tag "sample_controlled_vocab[sample_controlled_vocab_terms_attributes][#{index}][id]", term.id %>
     <%= hidden_field_tag "sample_controlled_vocab[sample_controlled_vocab_terms_attributes][#{index}][label]", term.label  %>
     <div class='disabled-cv-field form-control'><%= term.label %></div>
   </td>