Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lega commander 100 files limit bug #188

Open
joshbaskaran opened this issue Jun 26, 2024 · 4 comments · May be fixed by #223
Open

Lega commander 100 files limit bug #188

joshbaskaran opened this issue Jun 26, 2024 · 4 comments · May be fixed by #223
Assignees

Comments

@joshbaskaran
Copy link
Contributor

LC only lists the 100 first files and ignores the rest. Also affects the "check if file already exists" test.

Could be a limitation that we only get 100 entries returned "by default?" from TSD File API?
NB: The current implementation allows the user to upload the same file twice, overwriting the first uploaded file, if user has more than 100 files in inbox.

@joshbaskaran
Copy link
Contributor Author

From the initial look, I don't think the problem is entirely on the lega-commander. We need to check the response from TSD side to see the shape of the response and what exactly we are getting. Probably gives a better understanding as to what we receive and make adjustments accordingly.

@pavelvazquez pavelvazquez self-assigned this Aug 15, 2024
@pavelvazquez pavelvazquez linked a pull request Aug 15, 2024 that will close this issue
@pavelvazquez
Copy link
Contributor

I reviewed the documentation (link) and confirmed that setting "per_page": "1000" adjusts the default file listing limit from 100 to 1000. I've updated this in the code. It needs testing to verify the change.

@kjellp
Copy link
Contributor

kjellp commented Aug 15, 2024

Excellent! I guess we also need a graceful way of handling a lot of files, sorting them etc, may already be a different card for this.

So nice we've found the reason/measure to get all the information, then we need to use that tool to implement both the "does a file exist already in the inbox" check and the task of "nicely and userfriendly display all the files to a user" :)

@pavelvazquez
Copy link
Contributor

I have submitted this an issue https://github.com/unioslo/tsd-file-api/issues/253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants