Increase file listing limit from 100 #223
Conversation
There was a problem hiding this comment.
Just my 2 cents here.
I think this should be merged in as a quick fix but we should implement proper handling of paginated requests. I don't know how common it would be for users to to have more than 1000 files but this will break the moment someone has 1001 files.
I guess we need to balance between convenience and performance. We can use the maximum page size of 50000 but I don't know if we will have performance issues. |
Apologies, probably should have been more clear. What I meant was that we should implement pagination on the lega-commander side. As in, the requests for more content is made when the user scrolls on the CLI instead of asking for all the data as once (which will have bandwidth cost and cause load times to get worse the more file that need to be listed. |
Parisa68
force-pushed
the
fix/list_limitation
branch
from
d79e6e9
to
008a4f1
Compare
|
I guess this work is not supposed to be merged? We had a lot of discussion on how the localega_tsd_proxy sits in between lega_commander and the tsd-file-api, and additional parameters to increase number of files per page and/or pagination, needs to be implemented all the way through lega-commander -> localega-tsd-proxy -> tsd-file-api-client -> tsd-file-api (tsd-file-api stays unchanged, but we use new parameters and maybe end-points) |
Fixes #188