chore: refactor token utils & impl a new service #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, documented the behaviour of the flow.
Parisa68
reviewed
Nov 22, 2024
| * @throws IllegalArgumentException if the JWT token format is invalid or the specified fragment | ||
| * is missing. | ||
| */ | ||
| public JsonObject extractFragmentFromJWT(String jwtToken, TokenFragment tokenFragment) { |
There was a problem hiding this comment.
private JsonObject extractFragmentFromJWT(String jwtToken, TokenFragment tokenFragment)
| * @link <a href="https://ga4gh.github.io/data-security/aai-openid-connect-profile">docs</a> | ||
| * @link <a href="https://ga4gh-echo.aai.lifescience-ri.eu/index.html">playground</a> | ||
| */ | ||
| public List<Visa> fetchTheFullPassportUsingPassportScopedAccessTokenAndGetVisas( |
There was a problem hiding this comment.
private List fetchTheFullPassportUsingPassportScopedAccessTokenAndGetVisas(
| * invalid token format, missing claims, or failure to access required resources (e.g., public | ||
| * key file or JWK endpoint). | ||
| */ | ||
| public Optional<Visa> verifyVisaTokenAndTransformToVisaObject(String visaToken) { |
There was a problem hiding this comment.
private Optional verifyVisaTokenAndTransformToVisaObject(String visaToken) {
| * included. | ||
| * @return {@code List<Visa>} filtered visas. | ||
| */ | ||
| public List<Visa> filterByVisaType(List<Visa> visas, VisaType visaType) { |
There was a problem hiding this comment.
private List filterByVisaType(List visas, VisaType visaType) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.