Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable pylint errors on too-many-positional-arguments #339

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,12 @@ datadoc = [
]
pre-commit = [
"pre-commit==4.0.1",
"pylint==2.15.5",
"pylint==3.3.4",
]
testing-core = [
"pytest==7.4.4",
"pytest-cov==4.1.0",
"pytest==8.3.4",
"pytest-cov==5.0.0; python_version<'3.9'",
"pytest-cov==6.0.0; python_version>='3.9'",
]
testing = [
"tripper[testing-core,mappings,datadoc]",
Expand Down
2 changes: 1 addition & 1 deletion tripper/backends/ontopy.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def remove(self, triple: "Triple"):
self.onto._del_obj_triple_spo(s, p, o)

# Optional methods
def parse(
def parse( # pylint: disable=too-many-positional-arguments
self,
source=None,
location=None,
Expand Down
2 changes: 1 addition & 1 deletion tripper/backends/rdflib.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class RdflibStrategy:

prefer_sparql = False

def __init__(
def __init__( # pylint: disable=too-many-positional-arguments
self,
base_iri: "Optional[str]" = None, # pylint: disable=unused-argument
database: "Optional[str]" = None,
Expand Down
6 changes: 3 additions & 3 deletions tripper/convert/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def get_obj_iri(obj, uuid):
return rdf


def save_container(
def save_container( # pylint: disable=too-many-positional-arguments
ts: "Triplestore",
container: "Union[Mapping[str, Any], Sequence[Any]]",
iri: str,
Expand Down Expand Up @@ -330,7 +330,7 @@ def get_obj(value):
# === Deprecated functions ===


def from_dict(
def from_dict( # pylint: disable=too-many-positional-arguments
dct: dict,
iri: str,
bases: "Optional[Sequence]" = None,
Expand Down Expand Up @@ -367,7 +367,7 @@ def from_dict(
)


def save_dict(
def save_dict( # pylint: disable=too-many-positional-arguments
ts: "Triplestore",
dct: "Mapping[str, Any]",
iri: str,
Expand Down
4 changes: 3 additions & 1 deletion tripper/datadoc/dataaccess.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
package.

"""
from __future__ import annotations

import secrets # From Python 3.9 we could use random.randbytes(16).hex()
from typing import TYPE_CHECKING
from urllib.parse import urlparse
Expand All @@ -24,7 +26,7 @@
from typing import Any, Iterable, List, Mapping, Optional, Sequence, Union


def save(
def save( # pylint: disable=too-many-positional-arguments
ts: Triplestore,
data: bytes,
class_iri: "Optional[str]" = None,
Expand Down
2 changes: 1 addition & 1 deletion tripper/datadoc/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ def as_jsonld(
return d


def get_partial_pipeline(
def get_partial_pipeline( # pylint: disable=too-many-positional-arguments
ts: Triplestore,
client,
iri: str,
Expand Down
4 changes: 2 additions & 2 deletions tripper/datadoc/tabledoc.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class TableDoc:

# pylint: disable=redefined-builtin,too-few-public-methods

def __init__(
def __init__( # pylint: disable=too-many-positional-arguments
self,
header: "Sequence[str]",
data: "Sequence[Sequence[str]]",
Expand Down Expand Up @@ -200,7 +200,7 @@ def addheaddict(d, prefix=""):
)

@staticmethod
def parse_csv(
def parse_csv( # pylint: disable=too-many-positional-arguments
csvfile: "Union[Iterable[str], Path, str]",
type: "Optional[str]" = "dataset",
prefixes: "Optional[dict]" = None,
Expand Down
6 changes: 3 additions & 3 deletions tripper/mappings/mappings.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class Value:

# pylint: disable=too-few-public-methods

def __init__(
def __init__( # pylint: disable=too-many-positional-arguments
self,
value: "Any" = None,
unit: "Optional[str]" = None,
Expand Down Expand Up @@ -204,7 +204,7 @@ class MappingStep:

# pylint: disable=too-many-instance-attributes

def __init__(
def __init__( # pylint: disable=too-many-positional-arguments
self,
output_iri: str,
steptype: "StepType" = StepType.UNSPECIFIED,
Expand Down Expand Up @@ -757,7 +757,7 @@ def fno_mapper(triplestore: "Triplestore") -> "Dict[str, list]":
return d


def mapping_routes(
def mapping_routes( # pylint: disable=too-many-positional-arguments
target: str,
sources: "Union[Dict[str, Union[Value, None]], Sequence[str]]",
triplestore: "Triplestore",
Expand Down
2 changes: 1 addition & 1 deletion tripper/namespace.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class Namespace:
"_format", # Format to use when loading from a triplestore
)

def __init__(
def __init__( # pylint: disable=too-many-positional-arguments
self,
iri: str,
label_annotations: "Union[Sequence, bool]" = (),
Expand Down
16 changes: 9 additions & 7 deletions tripper/triplestore.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@ def _load_backend(cls, backend: str, package: "Optional[str]" = None):
# Installed backend package
if sys.version_info < (3, 10):
# Fallback for Python < 3.10
eps = entry_points().get("tripper.backends", ())
eps = entry_points().get( # pylint: disable=no-member
"tripper.backends", ()
)
else:
# New entry_point interface from Python 3.10+
eps = entry_points( # pylint: disable=unexpected-keyword-arg
Expand Down Expand Up @@ -611,7 +613,7 @@ def add(self, triple: "Triple"):
"""Add `triple` to triplestore."""
self.add_triples([triple])

def value( # pylint: disable=redefined-builtin
def value( # pylint: disable=redefined-builtin,too-many-positional-arguments
self,
subject=None,
predicate=None,
Expand Down Expand Up @@ -822,7 +824,7 @@ def prefix_iri(self, iri: str, require_prefixed: bool = False):
"value": (OWL.hasValue, None),
}

def add_restriction( # pylint: disable=redefined-builtin
def add_restriction( # pylint: disable=redefined-builtin,too-many-positional-arguments
self,
cls: str,
property: str,
Expand Down Expand Up @@ -884,7 +886,7 @@ def add_restriction( # pylint: disable=redefined-builtin
self.add_triples(triples)
return iri

def restrictions( # pylint: disable=redefined-builtin
def restrictions( # pylint: disable=redefined-builtin,too-many-positional-arguments
self,
cls: "Optional[str]" = None,
property: "Optional[str]" = None,
Expand Down Expand Up @@ -1025,7 +1027,7 @@ def map(
target_cost=target_cost,
)

def add_mapsTo(
def add_mapsTo( # pylint: disable=too-many-positional-arguments
self,
target: str,
source: str,
Expand Down Expand Up @@ -1169,7 +1171,7 @@ def eval_function(self, func_iri, args=(), kwargs=None) -> "Any":

return result

def add_function(
def add_function( # pylint: disable=too-many-positional-arguments
self,
func: "Union[Callable, str]",
expects: "Union[str, Sequence, Mapping]" = (),
Expand Down Expand Up @@ -1244,7 +1246,7 @@ def add_function(

return func_iri

def _add_function_doc(
def _add_function_doc( # pylint: disable=too-many-positional-arguments
self,
func_iri: "str",
func: "Optional[Callable]" = None,
Expand Down
6 changes: 3 additions & 3 deletions tripper/triplestore_extend.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Tripper(Triplestore):
such as get_value, add_data and add_interpolation_source.
"""

def add_data(
def add_data( # pylint: disable=too-many-positional-arguments
self,
func: "Union[Callable, Literal]",
iri: "Optional[Union[str, Sequence]]" = None,
Expand Down Expand Up @@ -121,7 +121,7 @@ def fn():

return data_source

def get_value(
def get_value( # pylint: disable=too-many-positional-arguments
self,
iri,
routeno=0,
Expand Down Expand Up @@ -209,7 +209,7 @@ def get_value(
quantity=quantity,
)

def add_interpolation_source( # pylint: disable=too-many-arguments
def add_interpolation_source( # pylint: disable=too-many-positional-arguments,too-many-arguments
self,
xcoord: str,
ycoord: str,
Expand Down