Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mod #139

Merged
merged 11 commits into from
Feb 17, 2023
Merged

feat: Mod #139

merged 11 commits into from
Feb 17, 2023

Conversation

JohnMasoner
Copy link
Contributor

No description provided.

@senysenyseny16 senysenyseny16 added the feat new feature for the user label Feb 16, 2023
onnx2torch/node_converters/mod.py Show resolved Hide resolved
onnx2torch/node_converters/mod.py Outdated Show resolved Hide resolved
tests/node_converters/mod_test.py Outdated Show resolved Hide resolved
tests/node_converters/mod_test.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@senysenyseny16 senysenyseny16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix typings and imports order?

tests/node_converters/mod_test.py Outdated Show resolved Hide resolved
@JohnMasoner
Copy link
Contributor Author

JohnMasoner commented Feb 17, 2023

Hey, @senysenyseny16,

I tried several times and could not solve the problem about imports order. It seems like this is similar to problem #1518.

tests/node_converters/mod_test.py Outdated Show resolved Hide resolved
onnx2torch/node_converters/mod.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@senysenyseny16 senysenyseny16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

p.s. in our repository there is pre-commit configuration. It automatically handles all formatting/sorting routine for you. Just install it pip install pre-commit and enable for repository: pre-commit install.

@JohnMasoner
Copy link
Contributor Author

Thanks.

p.s. in our repository there is pre-commit configuration. It automatically handles all formatting/sorting routine for you. Just install it pip install pre-commit and enable for repository: pre-commit install.

Many Thanks, This information was very helpful to me.

@senysenyseny16 senysenyseny16 merged commit 02f2b5c into ENOT-AutoDL:main Feb 17, 2023
@senysenyseny16
Copy link
Collaborator

@JohnMasoner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat new feature for the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants