Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev in main ✨ #24

Merged
merged 70 commits into from
Jun 2, 2023
Merged

Merge dev in main ✨ #24

merged 70 commits into from
Jun 2, 2023

Conversation

o-laurent
Copy link
Contributor

@o-laurent o-laurent commented May 26, 2023

  • Update packages ⚑
  • Remove useless functional transforms πŸ”₯
  • Add a link to Packed-Ensembles medium post πŸ“–
  • Add ImageNet variations ✨
  • Don't compute coverage on datasets and load_pretrained methods
  • Merge baselines simplifications PR πŸ”¨
  • Add tests (missing for transforms & pixmix)
  • Add update package procedure

o-laurent and others added 24 commits May 15, 2023 15:01
Increase legibility of the raw Readme
Slightly improve docstrings πŸ“š
Add a dummy network
Make the dummy dataset class more flexible
Add the pre-commit-hooks package βž•
Solve the new hooks' issues πŸ’„
Create a contributing page πŸ“š
Add a reference to WR πŸ“–
Add dummy baselines and datamodules ✨
Fix dummy models and datasets πŸ›
Temporary solution for the note issue on the installation page :docs:
@o-laurent o-laurent added the enhancement New feature or request label May 26, 2023
@o-laurent o-laurent self-assigned this May 26, 2023
@o-laurent o-laurent requested a review from alafage May 26, 2023 14:39
@o-laurent
Copy link
Contributor Author

The current code is acceptable to me for merging.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 91.61% and project coverage change: +5.12 πŸŽ‰

Comparison is base (3576012) 86.75% compared to head (126d9d3) 91.88%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   86.75%   91.88%   +5.12%     
==========================================
  Files          90       81       -9     
  Lines        3291     3449     +158     
  Branches      231      287      +56     
==========================================
+ Hits         2855     3169     +314     
+ Misses        351      190     -161     
- Partials       85       90       +5     
Flag Coverage Ξ”
cpu 91.88% <91.61%> (+5.12%) ⬆️
pytest 91.88% <91.61%> (+5.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
tests/_dummies/transform.py 100.00% <ΓΈ> (ΓΈ)
...h_uncertainty/baselines/classification/__init__.py 100.00% <ΓΈ> (ΓΈ)
torch_uncertainty/layers/batchens_layers.py 100.00% <ΓΈ> (+2.85%) ⬆️
torch_uncertainty/models/wideresnet/packed.py 93.84% <ΓΈ> (ΓΈ)
torch_uncertainty/models/resnet/packed.py 60.31% <10.81%> (-17.35%) ⬇️
torch_uncertainty/datamodules/cifar10.py 80.72% <20.00%> (-0.53%) ⬇️
torch_uncertainty/datamodules/imagenet.py 63.63% <43.58%> (-3.84%) ⬇️
torch_uncertainty/__init__.py 77.77% <79.16%> (+26.71%) ⬆️
torch_uncertainty/datamodules/tiny_imagenet.py 91.22% <83.33%> (+0.48%) ⬆️
tests/_dummies/baseline.py 93.75% <93.75%> (ΓΈ)
... and 43 more

... and 12 files with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@alafage alafage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the state of this pull request is fine enough to be merged.

@alafage alafage merged commit c4b1aaa into main Jun 2, 2023
@o-laurent o-laurent deleted the dev branch June 2, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants