Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: reference scene heuristic and uniform pixel size in SceneCollection returned from mapper #91

Merged

Conversation

lukasValentin
Copy link
Collaborator

This PR addresses and resolves #90:

  • we now ensure that all scenes in a SceneCollection returned from a mapper call not only have the same spatial extent but also the same pixel size. This was not necessarily the case before as there was no proper, fixed reference scene used. The problem became evident when reading Sentinel-2 data from different UTM zones. Please note that this is just a technical alignment of grids, we do not check for geolocalisation inaccuracies as we assume the reported geo-referencation to be correct (e.g., from ESA).
  • also, we now ensure that spatial reprojection is only called when really necessary

@lukasValentin lukasValentin self-assigned this Nov 19, 2023
@lukasValentin lukasValentin added this to the v0.2.3 milestone Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ff0a54) 57.79% compared to head (25ff686) 57.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   57.79%   57.85%   +0.06%     
==========================================
  Files          68       68              
  Lines        5324     5332       +8     
  Branches     1068     1071       +3     
==========================================
+ Hits         3077     3085       +8     
  Misses       1937     1937              
  Partials      310      310              
Flag Coverage Δ
unittests 57.85% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasValentin lukasValentin merged commit 6356751 into EOA-team:master Nov 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: No proper heuristic for selection of reference in EOdal mapper
1 participant