Fix sign in offset for scaling and selection of reference bands for Landsat #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sign of the offset has been changed from calculating
value * scale - offset
tovalue * scale + offset
. The offset for Sentinel-2 scenes with PDGS baseline >= 4.00 has been changed accordingly from0.1
to-0.1
. Now, the scaling behaviour in EOdal is the same as in QGIS.In addition, there was a small bug in the mapper when calling it for Landsat with different sensor generations (OLI versus ETM). Bands that do not exist in the reference scene (e.g., bands OLI has but not ETM) are discarded to make sure all scenes in the collection share the same bands. The bands affected are mainly same auxiliary quality bands such as
qa_aerosol
. If you need to have, you have to make sure that you only select scenes from Landsat-8 or -9.