Fixed Missing Device Selector for xiaomi_wxkg11lm Zigbee2MQTT to include Aqara. #690
+79
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @EPMatt, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
yarafie
changed the title
EPMatt
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
LGTM, thank you for the quick fix @yarafie.
Before merging this:
- Let's remember to also bump version number to
2025-02-16 - I did a quick research. It looks like the Xiaomi WXKG01LM is a different device than the Aqara WXKG11LM. Hence, I believe we should add an entry to the Controllers docs with a separate image. No need to duplicate the actual blueprint as long as the interface of the two device is exactly the same.
No need to do anything on your side, I can take care of this later today.
…Mi Wireless Switch in hooks, change controller blueprint name
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2025
…aomi_wxkg11lm Zigbee2MQTT to include Aqara. (#690) * Fixed Missing Device Selector for Zigbee2MQTT to include Aqara. * docs: add separate entry for aqara and xiaomi controllers * feat: separate Aqara WXKG11LM Wireless Mini Switch / Xiaomi WXKG01LM Mi Wireless Switch in hooks, change controller blueprint name * docs: bump hook version to 2025.02.16, update changelogs * npm run format --------- Co-authored-by: EPMatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Proposed change*
Fixed Missing Device Selector for Zigbee2MQTT to include Aqara.
Addresses:
Fixes #686
Checklist*
npm run formatbefore submitting my Pull Request.