Skip to content

Fix/datavalidation copy quadtree #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

OssianEPPlus
Copy link
Contributor

@OssianEPPlus OssianEPPlus commented Apr 9, 2025

Before submitting this pull request I have...

  • read EPPlus Softwares Contribution Guidlines
  • ensured that the functionality I have added/changed is covered by new unit tests.
  • merged the target branch into the PR branch and resolved any merge conflicts
  • Run all the unit tests and ensured that they all are green (unless the purpose of the PR is to provide us with failing unit tests).

Fix for #1310
Also improved copying with conditional formattings

@OssianEPPlus OssianEPPlus requested a review from JanKallman April 9, 2025 14:00

internal void AddToQuadTree(ExcelDataValidation validation)
{
var internalAddress = new ExcelAddress(validation.Address.Address.Replace(" ", ","));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove foreach and uncommented code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

hs.Add(v);
}
}
//return hs.OrderBy(x => x.Priority).ToList();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

}
}

//ws.Cells["A1:B10"].DataValidation.ClearDataValidation(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Cleaned up

@JanKallman JanKallman merged commit deef5d3 into develop8_1 Apr 14, 2025
@JanKallman JanKallman deleted the fix/datavalidation-copy-quadtree branch April 14, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants