-
Notifications
You must be signed in to change notification settings - Fork 293
Fix/datavalidation copy quadtree #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
internal void AddToQuadTree(ExcelDataValidation validation) | ||
{ | ||
var internalAddress = new ExcelAddress(validation.Address.Address.Replace(" ", ",")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove foreach and uncommented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
hs.Add(v); | ||
} | ||
} | ||
//return hs.OrderBy(x => x.Priority).ToList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
} | ||
} | ||
|
||
//ws.Cells["A1:B10"].DataValidation.ClearDataValidation(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Cleaned up
Before submitting this pull request I have...
Fix for #1310
Also improved copying with conditional formattings