fix: Repair isDataAuthentic #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: merge to main
…-main--components--erc725.js chore(main): release 0.24.1
Sync with main to release
…-main--components--erc725.js chore(main): release 0.24.2
sync main to release
…-main--components--erc725.js chore(main): release 0.25.0
sync again with main to re-release
…-main--components--erc725.js chore(main): release 0.25.0
…-main--components--erc725.js chore(main): release 0.25.0
sync main to create next release
…-main--components--erc725.js chore: release 0.26.0
sync main to release
…-main--components--erc725.js chore(main): release 0.26.0
sync main to release
…-main--components--erc725.js chore(main): release 0.27.0
rebase: Merge develop to main
…-main--components--erc725.js chore(main): release 0.27.1
…in isDataAuthentic
richtera
force-pushed
the
fix/method-zero
branch
from
592cb2e to
06cc24c
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #474 +/- ##
===========================================
+ Coverage 83.71% 87.44% +3.72%
===========================================
Files 18 22 +4
Lines 1130 1473 +343
Branches 255 340 +85
===========================================
+ Hits 946 1288 +342
- Misses 98 174 +76
+ Partials 86 11 -75 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
One case where
{ verification: { method: "0x000000000" } }was still causing a problembecause it was only check for method == null.
What is the current behaviour (you can also link to an open issue here)?
I kept on seeing method 0x00000000 verifications failing during the indexing process.
What is the new behaviour (if this is a feature change)?
It should correctly assume those verifications to be valid.
Other information: