-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python Basics Notebook #27
base: jbook
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -0,0 +1,873 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider saying "assign the value of an expression to a variable" instead of "assign an expression to a variable" in the markdown cell about assigning variables.
Reply via ReviewNB
@@ -0,0 +1,873 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,873 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #1. # calculate something with your variables - what might we want to calculate with deltaH, deltaS, and temp?
Consider explicitly instructing them to calculate deltaG since you expect them to have the value later when they use the round function.
Reply via ReviewNB
@@ -0,0 +1,873 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider saying "There is a built-in Python function called round
that we can use to round..." rather than "We can use the round
function."
Also wondering if a very brief mention that there are both "built-in" and user-defined functions in python?
Reply via ReviewNB
@@ -0,0 +1,873 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janash This is a great intro! I will think about the python chapter name (vs some other chapter name, like 'introductory material' or something) a bit more while you consider the few small edits I suggested. |
Hey @FoleyLab - I've addressed your comments! Would love another review. Thanks! |
@FoleyLab - just a reminder |
This PR adds a notebook with and Introduction to Python. It covers basic syntax, setting variables, data types, for loops, and conditionals. This is very closely modeled after the MolSSI intro lesson, but has expanded content related to using Python and some other conceptual areas.
This PR also adds more files to the
.gitignore
so that standard Python files are covered.The notebook includes a link to a Google Colab notebook with the same content.
I wasn't sure where to put this general type of notebook, so I created a new directory called "python" for standard Python tutorials.