Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_067: Remove SPCAM #1217

Merged
merged 9 commits into from
Feb 15, 2025
Merged

Conversation

brian-eaton
Copy link
Collaborator

Resolve #1171 - Remove SP-CAM from cam_development

@brian-eaton brian-eaton added the BFB bit for bit tag label Jan 2, 2025
@brian-eaton brian-eaton self-assigned this Jan 2, 2025
@cacraigucar cacraigucar self-requested a review January 2, 2025 21:42
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes all look good. I did a grep through the source code tree and saw SPCAM mentioned in ReleaseNotes. Since it says CAM5.4, and we didn't update it for CAM6, I'd say lets go ahead and remove that file completely.

@cacraigucar cacraigucar changed the title Remove SPCAM cam6_4_067: Remove SPCAM Feb 13, 2025
@brian-eaton
Copy link
Collaborator Author

The old ReleaseNotes file has been removed.

@brian-eaton brian-eaton merged commit a01a051 into ESCOMP:cam_development Feb 15, 2025
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Feb 19, 2025
Merge pull request ESCOMP#1217 from brian-eaton/rm-spcam

cam6_4_067: Remove SPCAM

ESCOMP commit: a01a051
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Feb 23, 2025
Merge pull request ESCOMP#1217 from brian-eaton/rm-spcam

cam6_4_067: Remove SPCAM

ESCOMP commit: a01a051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB bit for bit tag CoupledEval3
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

2 participants