-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_4_067: Remove SPCAM #1217
Merged
Merged
cam6_4_067: Remove SPCAM #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacraigucar
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes all look good. I did a grep through the source code tree and saw SPCAM mentioned in ReleaseNotes. Since it says CAM5.4, and we didn't update it for CAM6, I'd say lets go ahead and remove that file completely.
The old ReleaseNotes file has been removed. |
cacraigucar
approved these changes
Feb 15, 2025
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Feb 19, 2025
Merge pull request ESCOMP#1217 from brian-eaton/rm-spcam cam6_4_067: Remove SPCAM ESCOMP commit: a01a051
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Feb 23, 2025
Merge pull request ESCOMP#1217 from brian-eaton/rm-spcam cam6_4_067: Remove SPCAM ESCOMP commit: a01a051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1171 - Remove SP-CAM from cam_development