Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tower types #2969

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Feb 18, 2025

Description of changes

Simplifies child types of TowerSite (NeonSite, Plumber2Site).

Moving here from the PR on my fork.

Remaining work

  • Resolve merge conflicts
  • Remove check for valid site type

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed: None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:
As of a91c855:

@samsrabin samsrabin added code health improving internal code structure to make easier to maintain (sustainability) bfb bit-for-bit test: python Pass clm_pymods test suite plus Python sys/unit tests before merging labels Feb 18, 2025
@samsrabin samsrabin self-assigned this Feb 18, 2025
@samsrabin samsrabin marked this pull request as draft February 18, 2025 23:44
@samsrabin samsrabin marked this pull request as ready for review February 19, 2025 00:20
@samsrabin samsrabin requested a review from TeaganKing February 19, 2025 00:20
@samsrabin
Copy link
Collaborator Author

@TeaganKing I moved this here from my repo and got rid of the site type checking as discussed. Could you re-review?

@TeaganKing
Copy link
Contributor

This generally looks good! I will test this out more thoroughly on Thursday.

@samsrabin samsrabin added PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete PR status: awaiting review Work on this PR is paused while waiting for review. and removed PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete labels Feb 19, 2025
Copy link
Contributor

@TeaganKing TeaganKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a few NEON & PLUMBER cases and they both seem to be working smoothly! Thanks for making these changes!

@samsrabin samsrabin merged commit 7a4365d into ESCOMP:b4b-dev Feb 20, 2025
2 checks passed
@samsrabin
Copy link
Collaborator Author

Thanks, @TeaganKing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) PR status: awaiting review Work on this PR is paused while waiting for review. test: python Pass clm_pymods test suite plus Python sys/unit tests before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants