-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify tower types #2969
Simplify tower types #2969
Conversation
@TeaganKing I moved this here from my repo and got rid of the site type checking as discussed. Could you re-review? |
This generally looks good! I will test this out more thoroughly on Thursday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a few NEON & PLUMBER cases and they both seem to be working smoothly! Thanks for making these changes!
Thanks, @TeaganKing! |
Description of changes
Simplifies child types of
TowerSite
(NeonSite
,Plumber2Site
).Moving here from the PR on my fork.
Remaining work
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed: None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
As of a91c855:
./run_neon --neon-sites TOOL --run-type ad
should complete without issues (see run_neon not working as expected for AD simulations #2739)clm_pymods
suite