Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default fates parameter file for new api 8.1.0 format. #870

Merged
merged 6 commits into from
Jan 4, 2020

Conversation

rgknox
Copy link
Collaborator

@rgknox rgknox commented Dec 13, 2019

Description of changes

This PR is synced with NGEET/fates#595
Changes here should only update the default fates parameter file location.

Tag info will be added last in Externals_CLM.cfg after tests pass and FATES side changes are integrated.

Specific notes

See: NGEET/fates#595

Are answers expected to change (and if so in what way)?

Since the parameter files are different, I don't think this will pass b4b tests, even though the values are all the same in the parameter file, and answers should not change. The parameter names have changed, and new parameter entries have been added that are not used yet.

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed, if any:

fates test suite, results TBD

@rgknox rgknox requested a review from glemieux December 13, 2019 21:23
Copy link
Collaborator

@glemieux glemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rgknox rgknox merged commit a0803e3 into ESCOMP:fates_next_api Jan 4, 2020
@rgknox rgknox deleted the fates-api-8.1.0 branch October 31, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants