-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwind support for Geoweaver - UI Enchanment #485
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # src/main/resources/templates/geoweaver.html
can someone test this please? |
@@ -151,4 +151,6 @@ | |||
|
|||
<script type="text/javascript" src="../js/intro.min.js"></script> | |||
|
|||
<link rel="stylesheet" href="../css/tailwind.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to add this in our project? can we use CDN here instead of including entire source of tailwindcss in our project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its better to use a local version
it is same across all the lib we use in the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it
We need to build the tailwind.css using the command
npm install tailwindcss --save-dev
npm run build:css
which will automatically build the tailwind.css for our project optimally
The tailwind functionality is working fine
Pls Add nodemodules inside .gitignore file to avoid nodemodules pushed into project mistakenly
Add the above css build step in the ci/cd
everything looks good to me
Please note that all tailwind classes are prefixed with
tw-
this is done to avoid conflicts with existing css classes.we can use all the CSS helper functions from https://tailwindui.com/?ref=top