-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NOT FOR CHANGELOG; PR NOT IN MAIN] Add mappings for ocean variables #2702
base: icon-xpp
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## icon-xpp #2702 +/- ##
=========================================
Coverage 95.13% 95.13%
=========================================
Files 257 257
Lines 15057 15057
=========================================
Hits 14324 14324
Misses 733 733 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zos: {raw_name: zos, var_type: oce_dbg} | ||
hfds: {raw_name: HeatFlux_Total, var_type: oce_dbg} | ||
sithick: {raw_name: hi, var_type: oce_ice} | ||
sic: {raw_name: conc, var_type: oce_ice, raw_units: '1'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find sic
in the CMOR tables, do you mean siconc
? In this case, we can remove it from above and put it here (siconca
, the sea ice concentration on the atm grid should stay above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sic
was the short_name
in CMIP5, hence it still worked in the recipe. If you think it should be the one from the atmosphere output anyways, the entry from the ocean variables could be deleted I suppose. Otherwise, it could be changed to siconc
to accomodate for both ocean and atmosphere output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since ICON uses the CMIP6 tables, I think siconc
would be better here.
This comment was marked as outdated.
This comment was marked as outdated.
I thought about this more, and I guess there's a more or less safe way to do this in general. You could check if a dimensional coordinate lev_coord = DimCoord(0.0, var_name="lev")
if cube.coords(lev_coord, dim_coords=True):
slices = [slice(None)] * cube.ndim
slices[cube.coord_dims(lev_coord)[0]] = 0
cube = cube[tuple(slices)]
cube.remove_coord(lev_coord) |
|
Remove the |
Mappings for ICON-XPP ocean variables.
The sea ice variables (sithick/sic) will need adjustments in the fix, since they have an extra "lev" dimension that is not expected by CMOR. I posted one possible generic solution in the comments of #2699. Otherwise, the variables would need to fixed be individually.
Moreover, variables like mixed layer depth (mlotst) or sea surface height (zos) might have different names/definitions in different output files. I added mappings of what I considered to be reasonable defaults.
Does not close but helps to close #2694
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: