Fb asim 295 improve widget #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
approved these changes
May 19, 2017
|
|
||
| :param str vertex_id: The id of the parent vertex. | ||
| :param str port_name: The port's name to remove. | ||
| """ |
There was a problem hiding this comment.
Perhaps we can add a test which at least ensures all api functions are covered? It can even test that the correct parameters are being passed.
There was a problem hiding this comment.
Covering it like that is the idea of #11.
Sorry for the missing code.
| """ | ||
| Create an image tag that could be embedded into a table contents. | ||
|
|
||
| The image's width and height and required since mxgraph will render the |
prusse-martin
force-pushed
the
fb-ASIM-295-improve-widget
branch
from
83d9f87 to
b2a4f84
Compare
- Properly render collapsed tables (there was a bug causing table collapsing unusable); - Child tables are supported (they position is relative to a "parent" cell); - An helper to create image tags to be embedded into tables; - CSS class names changes to make them less prone to be miss interpreted;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.