Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable automatic addition of trailing commas in JS #142

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Disable automatic addition of trailing commas in JS #142

merged 1 commit into from
Sep 20, 2022

Conversation

prusse-martin
Copy link
Member

@prusse-martin prusse-martin commented Sep 19, 2022 •
edited
Loading

Created issue to tackle the update #143.

Thanks @cauebs for helping with the trailing commas issue.

@prusse-martin prusse-martin force-pushed the fb-fix-js-tests branch 2 times, most recently from ab2ce5d to 755f827 Compare September 19, 2022 20:54
@prusse-martin prusse-martin changed the title WIP Revert to older "prettier" pre-commit-hook version Sep 19, 2022
@prusse-martin prusse-martin self-assigned this Sep 19, 2022
@prusse-martin prusse-martin marked this pull request as ready for review September 19, 2022 20:58
@prusse-martin
Copy link
Member Author

Note that master branch is failing:
https://github.com/ESSS/qmxgraph/actions?query=branch%3Amaster

cauebs
cauebs reviewed Sep 20, 2022
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@prusse-martin prusse-martin changed the title Revert to older "prettier" pre-commit-hook version Disable automatic addition of trailing commas in JS Sep 20, 2022
cauebs
cauebs approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@cauebs cauebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just don't forget to rename the PR before merging.

@prusse-martin prusse-martin merged commit a09ed22 into master Sep 20, 2022
@prusse-martin prusse-martin deleted the fb-fix-js-tests branch September 20, 2022 19:55
@nicoddemus nicoddemus mentioned this pull request Oct 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauebs cauebs cauebs approved these changes

@nicoddemus nicoddemus Awaiting requested review from nicoddemus

Assignees

@prusse-martin prusse-martin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prusse-martin @cauebs