Add unit tests to test generated code. SAP and SessionSetupReq #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiebrenW
force-pushed
the
feature/unit_tests
branch
from
c2fbcb9
to
691a78d
Compare
|
Codacy has a false positive, claiming an unused field in a test fixture. It is in fact used. |
Signed-off-by: Siebren Weertman <[email protected]> Cleanup
SiebrenW
force-pushed
the
feature/unit_tests
branch
from
691a78d
to
7f0fa94
Compare
This is a known issue with Codacy, don't worry for now. |
We have some ideas for these, will integrate those while working on integrating your tests. |
added 2 commits
February 26, 2024 13:10
Signed-off-by: Siebren Weertman <[email protected]>
Signed-off-by: Siebren Weertman <[email protected]>
SiebrenW
force-pushed
the
feature/unit_tests
branch
from
81d4594
to
5ebc93b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to hear some feedback and maybe some ideas about how to automate the running of these tests in a more hands-off manner. The repo is missing the schemas for one, so those should be fetched somehow I suppose.
Other than that, I chose gtest, because I had it installed and the like. Do tell if the CMakeLists works for everyone if they have gtest/gmock installed.
The CMakeLists for the library resides in the tests dir too, let me know if you have a better idea.
Anyways. Roast my code.