Address review comments

Signed-off-by: Cornelius Claussen <[email protected]>
EVerest · Dec 22, 2023 · d24b64f · d24b64f
1 parent 740da25
commit d24b64f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/modules/EvseManager/Charger.cpp b/modules/EvseManager/Charger.cpp
@@ -461,7 +461,6 @@ void Charger::runStateMachine() {
 
                 if (!powerAvailable()) {
                     pauseChargingWaitForPower();
-                    // FIXME new in state breaks
                     break;
                 }
 
@@ -545,9 +544,6 @@ void Charger::runStateMachine() {
 
                 if (initialize_state) {
                     signalEvent(types::evse_manager::SessionEventEnum::ChargingPausedEV);
-                    // bsp->allow_power_on(true, types::evse_board_support::Reason::FullPowerCharging);
-                    //  make sure we are enabling PWM
-                    // update_pwm_now(ampereToDutyCycle(getMaxCurrent()));
                 } else {
                     // update PWM if it has changed and 5 seconds have passed since last update
                     if (!errors_prevent_charging()) {

diff --git a/modules/EvseManager/Charger.hpp b/modules/EvseManager/Charger.hpp
@@ -142,11 +142,6 @@ class Charger {
 
     void notifyCurrentDemandStarted();
 
-    // Note: Deprecated, do not use EvseState externally.
-    // Kept for compatibility, will be removed from public interface
-    // in the future.
-    // Use new EvseEvent interface instead.
-
     enum class EvseState {
         Disabled,
         Idle,
@@ -173,8 +168,6 @@ class Charger {
 
     EvseState getCurrentState();
     sigslot::signal<EvseState> signalState;
-    // sigslot::signal<types::evse_manager::ErrorEnum> signalError;
-    //  /Deprecated
 
     void inform_new_evse_max_hlc_limits(const types::iso15118_charger::DC_EVSEMaximumLimits& l);
     types::iso15118_charger::DC_EVSEMaximumLimits get_evse_max_hlc_limits();