Feature/powermeter interface adaptions #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klemmpnx
force-pushed
the
feature/powermeter-interface-adaptions
branch
from
703097f to
8b8f78a
Compare
switch cable id and tariff ids to integer; add start and stop transaction responses Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
klemmpnx
force-pushed
the
feature/powermeter-interface-adaptions
branch
from
2d50437 to
4b766f9
Compare
Signed-off-by: Fabian Klemm <[email protected]>
corneliusclaussen
requested changes
Sep 19, 2023
types/powermeter.yaml
Outdated
| additionalProperties: false | ||
| required: | ||
| - status | ||
| - transaction_id |
There was a problem hiding this comment.
transaction_id is required but not defined
| std::string powermeterImpl::handle_stop_transaction(std::string& transaction_id) { | ||
| return "NOT_SUPPORTED"; | ||
| types::powermeter::TransactionStopResponse powermeterImpl::handle_stop_transaction(std::string& transaction_id) { | ||
| return {.status = types::powermeter::TransactionRequestStatus::NOT_SUPPORTED, |
There was a problem hiding this comment.
The designated initializers for structs (the dot notation) is valid C99 afaik but not in C++17 (it was added in C++20 I think). GCC supports a lot of C99 while compiling C++ but this may not be portable when using other compilers
| return true; | ||
| types::powermeter::TransactionStartResponse | ||
| powermeterImpl::handle_start_transaction(types::powermeter::TransactionReq& value) { | ||
| return {.status = types::powermeter::TransactionRequestStatus::OK}; |
There was a problem hiding this comment.
see comment below about designated inits
| @@ -45,18 +45,20 @@ std::string powermeterImpl::handle_stop_transaction(std::string& transaction_id) | |||
|
|
|||
| bsm::SignedOCMFSnapshot signed_snapshot(data); | |||
|
|
|||
| return signed_snapshot.O(); | |||
| return {.status = types::powermeter::TransactionRequestStatus::OK, .ocmf = signed_snapshot.O()}; | |||
| return false; | ||
| types::powermeter::TransactionStartResponse | ||
| powermeterImpl::handle_start_transaction(types::powermeter::TransactionReq& value) { | ||
| return {.status = types::powermeter::TransactionRequestStatus::NOT_SUPPORTED, |
| std::string powermeterImpl::handle_stop_transaction(std::string& transaction_id) { | ||
| return "NOT_SUPPORTED"; | ||
| types::powermeter::TransactionStopResponse powermeterImpl::handle_stop_transaction(std::string& transaction_id) { | ||
| return {.status = types::powermeter::TransactionRequestStatus::NOT_SUPPORTED, |
| return false; | ||
| types::powermeter::TransactionStartResponse | ||
| powermeterImpl::handle_start_transaction(types::powermeter::TransactionReq& value) { | ||
| return {.status = types::powermeter::TransactionRequestStatus::NOT_SUPPORTED, |
| std::string powermeterImpl::handle_stop_transaction(std::string& transaction_id) { | ||
| return "NOT_SUPPORTED"; | ||
| types::powermeter::TransactionStopResponse powermeterImpl::handle_stop_transaction(std::string& transaction_id) { | ||
| return {.status = types::powermeter::TransactionRequestStatus::NOT_SUPPORTED, |
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
|
@corneliusclaussen : thx for the review! I applied everything you mentioned. There is a final eslint complaint about unused variables; however, that is a common thing in the |
corneliusclaussen
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the Powermeter Interface and types:
Follow up adaptions of the mopdules