feat: Add configuration option to delay message queue resume #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikinggrass
requested changes
Dec 7, 2023
| @@ -24,6 +24,10 @@ config: | |||
| description: If true websocket can be disconnected and connected externally | |||
| type: boolean | |||
| default: false | |||
| MessageQueueResumeDelay: | |||
There was a problem hiding this comment.
Probably makes sense to have this in the OCPP (1.6) module as well
There was a problem hiding this comment.
We would need to extend the libocpp PR a bit as well, in order to allow passing that setting to the 1.6 chargepoint. Should we do that as part of this PR?
Signed-off-by: Valentin Dimov <[email protected]>
Signed-off-by: Valentin Dimov <[email protected]>
Signed-off-by: Valentin Dimov <[email protected]>
valentin-dimov
force-pushed
the
vd-delay-message-queue-resume-after-reconnect
branch
from
0f284d4 to
4ba9cbb
Compare
hikinggrass
approved these changes
Dec 7, 2023
Signed-off-by: Valentin Dimov <[email protected]>
valentin-dimov
deleted the
vd-delay-message-queue-resume-after-reconnect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to EVerest/libocpp#283