OCPP: Adjusted argument of on_session_started from string to SessionStartedReason #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikinggrass
approved these changes
Jan 13, 2024
|
Looks good, just needs a version bump for the libocpp dependency once EVerest/libocpp#402 is merged |
a-w50
reviewed
Jan 15, 2024
| return ocpp::SessionStartedReason::EVConnected; | ||
| case types::evse_manager::StartSessionReason::Authorized: | ||
| return ocpp::SessionStartedReason::Authorized; | ||
| default: |
There was a problem hiding this comment.
@Pietfried best practice here is to do the throw outside of the switch. That way the compiler might see, that some switch cases are missing (for example, if new values are added to the enum).
…string to ocpp::SessionStartedReason Signed-off-by: pietfried <[email protected]>
Pietfried
force-pushed
the
feature/adjust-session-started-reason
branch
from
6798d38 to
f319e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted changed argument type for reason of on_session_started from string to ocpp::SessionStartedReason.
This change is required by: EVerest/libocpp#402