IMDSimulator: Add C++ simulation module #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the comments from #499 apply here as well |
mhei
reviewed
Jan 19, 2024
| description: Measurement update interval in milliseconds | ||
| type: integer | ||
| default: 1000 | ||
| enable_external_mqtt: true |
There was a problem hiding this comment.
Since mqtt is not used directly in the module, this can be set to false.
barsnick
force-pushed
the
cb-add-imd-simulator
branch
2 times, most recently
from
c8609c2 to
d81a8df
Compare
corneliusclaussen
approved these changes
Jan 24, 2024
This C++ module replaces JsIMDSimulator. Co-authored-by: Cornelius Claussen <[email protected]> Co-authored-by: Fabian Hartung <[email protected]> Co-authored-by: Moritz Barsnick <[email protected]> Signed-off-by: Fabian Hartung <[email protected]> Signed-off-by: Moritz Barsnick <[email protected]>
barsnick
force-pushed
the
cb-add-imd-simulator
branch
from
d81a8df to
84f799d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This C++ module supplements JsIMDSimulator.
Co-authored-by: Cornelius Claussen [email protected]
Co-authored-by: Fabian Hartung [email protected]
Co-authored-by: Moritz Barsnick [email protected]