DCSupplySimulator: remove designated assignments #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barsnick
referenced
this pull request
Jan 25, 2024
This C++ module emulates the behavior of the existing JsDCSupplySimulator. Unlike JsDCSupplySimulator, it does not provide the powermeter simulation interface though. This should be implemented in a separate C++ module. Co-authored-by: Cornelius Claussen <[email protected]> Co-authored-by: Fabian Hartung <[email protected]> Co-authored-by: Mohannad Oraby <[email protected]> Co-authored-by: Moritz Barsnick <[email protected]> Signed-off-by: Fabian Hartung <[email protected]> Signed-off-by: Moritz Barsnick <[email protected]>
a-w50
reviewed
Jan 25, 2024
modules/simulation/DCSupplySimulator/main/power_supply_DCImpl.cpp
Outdated
Show resolved
Hide resolved
corneliusclaussen
approved these changes
Feb 9, 2024
These assignments are only supported from C++20 upwards. Use a static function, and get the capabilities from the config at runtime instead of storing them in an additional struct. Fixes EVerest@3b6a044#r137725550 Also fix typos in the *DCSupplySimulator manifests. Signed-off-by: Moritz Barsnick <[email protected]>
barsnick
force-pushed
the
cb-dcsupplysimulator-remove-designated-assignments
branch
from
5b1edc6 to
6c2e1b3
Compare
barsnick
deleted the
cb-dcsupplysimulator-remove-designated-assignments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are only officially supported from C++20 upwards.
While at it, also fix a description typo in the manifest(s).