EvseManager Charger: simply locking #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
force-pushed
the
refactor/EvseManager_remove_recursive_mutex
branch
from
cf5896f to
990142e
Compare
Remove recursive mutexes, reduce scope that needs locking. Also adapting to newer EVerest coding style. Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
refactor/EvseManager_remove_recursive_mutex
branch
from
511f891 to
e2d0458
Compare
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
reviewed
Jan 25, 2024
hikinggrass
requested changes
Jan 25, 2024
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
non recursive not possible with current threading Signed-off-by: Cornelius Claussen <[email protected]>
hikinggrass
reviewed
Jan 26, 2024
Co-authored-by: Kai Hermann <[email protected]> Signed-off-by: corneliusclaussen <[email protected]>
hikinggrass
approved these changes
Jan 26, 2024
corneliusclaussen
deleted the
refactor/EvseManager_remove_recursive_mutex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Charger class in EvseManager had a quite complicated locking concept with two (recusive) mutexes. This PR simplies locking with a single mutex using only scoped locking. A few cases where locking was not neccessary were removed.