Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust examples #515

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Conversation

golovasteek
Copy link
Contributor

@golovasteek golovasteek commented Jan 26, 2024

With this commit the Rust support in everest is feature complete. Updated examples can be used as base for the real modules.

In this merge request we update rust examples:

  • to correspond the recent changes in the framework
  • to use auto-generation
  • to support build with Bazel as well

@golovasteek golovasteek marked this pull request as draft January 26, 2024 22:21
Dima Dorezyuk and others added 4 commits January 27, 2024 06:25
* Add bazel support

* reviewer remarks

Signed-off-by: Dima Dorezyuk <[email protected]>

---------

Signed-off-by: Dima Dorezyuk <[email protected]>
Co-authored-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Evgeny Petrov <[email protected]>
Signed-off-by: Dima Dorezyuk <[email protected]>
Co-authored-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Evgeny Petrov <[email protected]>
Co-authored-by: Dima Dorezyuk <[email protected]>
Signed-off-by: Evgeny Petrov <[email protected]>
@golovasteek golovasteek marked this pull request as ready for review January 27, 2024 05:32
Copy link
Contributor

@SirVer SirVer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Amazing how close we got to the final API in our first shot....

@dorezyuk
Copy link
Contributor

dorezyuk commented Feb 6, 2024

Maybe tag me and holger as co-authors

@golovasteek
Copy link
Contributor Author

Maybe tag me and holger as co-authors

Yes sure.
You are already author of most of the commits here:

image

Or do you mean something else?

@hikinggrass hikinggrass merged commit d40971c into EVerest:main Feb 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants