-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rust examples #515
Merged
Merged
Update rust examples #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golovasteek
force-pushed
the
update/rust_examples
branch
from
January 27, 2024 05:12
b680231
to
78cec6f
Compare
* Add bazel support * reviewer remarks Signed-off-by: Dima Dorezyuk <[email protected]> --------- Signed-off-by: Dima Dorezyuk <[email protected]> Co-authored-by: Dima Dorezyuk <[email protected]> Signed-off-by: Evgeny Petrov <[email protected]>
Signed-off-by: Dima Dorezyuk <[email protected]> Co-authored-by: Dima Dorezyuk <[email protected]> Signed-off-by: Evgeny Petrov <[email protected]>
Co-authored-by: Dima Dorezyuk <[email protected]> Signed-off-by: Evgeny Petrov <[email protected]>
Signed-off-by: Evgeny Petrov <[email protected]>
golovasteek
force-pushed
the
update/rust_examples
branch
from
January 27, 2024 05:25
57aa737
to
0ead054
Compare
Signed-off-by: Evgeny Petrov <[email protected]>
golovasteek
force-pushed
the
update/rust_examples
branch
from
January 27, 2024 05:28
0ead054
to
d324b75
Compare
SirVer
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Amazing how close we got to the final API in our first shot....
Maybe tag me and holger as co-authors |
hikinggrass
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit the Rust support in everest is feature complete. Updated examples can be used as base for the real modules.
In this merge request we update rust examples: