Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersistentStore: Link stdc++fs for GCC<9 #552

Closed
wants to merge 1 commit into from
Closed

PersistentStore: Link stdc++fs for GCC<9 #552

wants to merge 1 commit into from

Conversation

hikinggrass
Copy link
Contributor

No description provided.

@hikinggrass
Link stdc++fs for GCC<9
fa52683 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@barsnick
Copy link
Contributor

I may have misunderstood the way it works, but why doesn't this propagate from the top-level CMakeLists.txt?

And/or why do other modules using std::filesystem not suffer the missing linked library?

@hikinggrass
Copy link
Contributor Author

I may have misunderstood the way it works, but why doesn't this propagate from the top-level CMakeLists.txt?

And/or why do other modules using std::filesystem not suffer the missing linked library?

You're right, this seems to be a non-issue these days

@hikinggrass hikinggrass deleted the bugfix/stdfilesystem-gcc-8 branch February 20, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusclaussen corneliusclaussen Awaiting requested review from corneliusclaussen corneliusclaussen is a code owner

@a-w50 a-w50 Awaiting requested review from a-w50

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hikinggrass @barsnick