-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup module to support WPA3 Wi-Fi networks #555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
force-pushed
the
feat-support-wpa3
branch
from
February 22, 2024 14:44
71d8e75
to
2959b26
Compare
james-ctc
force-pushed
the
feat-support-wpa3
branch
from
February 22, 2024 15:15
2959b26
to
7febcb5
Compare
Tested on WPA3 and WPA2 and mixed WPA3/2 networks |
re-reading the README for the Setup module and the configured networks list should be a single list rather than a list per wifi network device. |
corneliusclaussen
approved these changes
Feb 23, 2024
Signed-off-by: James Chapman <[email protected]>
WpaCliSetup extended to support open, WPA2 and WPA3. By default it attempts to configure based on the existing arguments. set_network can take an additional argument to explicitly choose the network security type. (this could be an additional parameter over MQTT). Note: WPA3 doesn't support pre shared key (64 hex ditits), it requires the password/passphrase. Hence over MQTT a quoted "psk": "\"thePassphrase\"" is required and not the output from the wpa_passphrase command. Signed-off-by: James Chapman <[email protected]>
Signed-off-by: James Chapman <[email protected]>
Signed-off-by: James Chapman <[email protected]>
Previously configured_networks published an array per wifi device which resulted in empty arrays where a device had no configured networks. Signed-off-by: James Chapman <[email protected]>
corneliusclaussen
force-pushed
the
feat-support-wpa3
branch
from
February 23, 2024 16:21
a27f7bc
to
571eaf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
wpa_cli
supports the configuration of WPA2 and WPA3 networks. However WPA3 doesn't support a pre-shared key (the output from the wpa_passphrase command), it always requires the plain text passphrase.By default the update will try and configure dual support for WPA2 and WPA3 based on the "psk": "" MQTT parameter
i.e.
additional
it is common for WiFi configuration to require the security being applied. Adding an additional parameter would allow EVerest to fully configure the network (and perhaps support more options: WEP, WPA2 Enterprise mode ...)
The WpaCliSetup has been updated to support network configuration with an additional parameter to indicate the network security to apply. This should make it easier to support new modes alongside an MQTT interface update.