Make soft over current timeout configurable #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wku12
requested review from
corneliusclaussen,
SebaLukas,
hikinggrass and
Pietfried
as code owners
Signed-off-by: Wojciech Kula <[email protected]>
wku12
force-pushed
the
feat/make_soft_over_current_timeout_configurable
branch
2 times, most recently
from
f58c22c
to
c05856e
Compare
|
How can I fix the failing build? |
|
Please update your branch with the latest main commit. Maybe the CI problem is fixed with this commit |
Signed-off-by: Wojciech Kula <[email protected]>
wku12
force-pushed
the
feat/make_soft_over_current_timeout_configurable
branch
from
8fd75a8
to
9bea3c0
Compare
corneliusclaussen
requested changes
Sep 16, 2024
…thub.com:wku12/everest-core into feat/make_soft_over_current_timeout_configurable
Signed-off-by: Wojciech Kula <[email protected]>
wku12
force-pushed
the
feat/make_soft_over_current_timeout_configurable
branch
from
e517849
to
3c0d02e
Compare
corneliusclaussen
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Some meters are not able to achieve 7s refresh rate. Therefore it makes sense to make this parameter configurable
Checklist before requesting a review