Adding ISO15118-20 dynamic mode support #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
requested review from
a-w50,
corneliusclaussen,
hikinggrass and
Pietfried
as code owners
corneliusclaussen
force-pushed
the
feat/adding-d20-dynamic-mode-support
branch
from
3ce818f
to
e9c7992
Compare
corneliusclaussen
approved these changes
Oct 25, 2024
SebaLukas
force-pushed
the
feat/adding-d20-dynamic-mode-support
branch
2 times, most recently
from
eac396e
to
b05bdb0
Compare
a-w50
approved these changes
Nov 13, 2024
Comment on lines
+415
to
+418
| const double latest_target_power = latest_target_voltage * latest_target_current; | ||
|
|
||
| if (latest_target_power <= PRE_CHARGE_MAX_POWER or values.min_charge_power > latest_target_power or | ||
| values.max_charge_power < latest_target_power) { |
There was a problem hiding this comment.
would do something like:
const auto latest_target_needs_update = [] (latest_target_voltage, latest_target_current) {
constexpr static auto PRE_CHARGE_MAX_POWER = ...;
const double power = .. x ...;
return (power <= PRE_CH.. or ... or ..);
}
if (latest_target_needs_update(latest_target_voltage, latest_target_current) {
...
just in order to give some more appropriate name to the more complex if condition because it is just not easy to reason what this is doing
a-w50
reviewed
Nov 13, 2024
D20 dynamic mode works now for IsoMux Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
…max limits in scheduled mode Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
Signed-off-by: Sebastian Lukas <[email protected]>
SebaLukas
force-pushed
the
feat/adding-d20-dynamic-mode-support
branch
from
1e60700
to
f7cd464
Compare
barsnick
pushed a commit
to chargebyte/everest-core
that referenced
this pull request
Nov 14, 2024
* Adding D20 dynamic mode support * Adding publish_dc_ev_max_limits call when the ev wants to change the max limits in scheduled mode Signed-off-by: Sebastian Lukas <[email protected]>
hikinggrass
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Adding D20 dynamic mode support * Adding publish_dc_ev_max_limits call when the ev wants to change the max limits in scheduled mode Signed-off-by: Sebastian Lukas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds with this libiso15118 Adding basic dynamic mode PR a basic support for ISO15118-20 dynamic mode.
Issue ticket number and link
Right now only a basic scheduled mode in the Evse15118D20 module was supported.
Checklist before requesting a review