Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC Power supply: perform mode switch only when it is on #952

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

corneliusclaussen
Copy link
Contributor

Describe your changes

In some cases for bidi DC, output voltage stayed on after the session was finished. The relays were always open in that case.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@hikinggrass hikinggrass added the include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible label Nov 12, 2024
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hikinggrass hikinggrass merged commit be97729 into main Nov 12, 2024
11 checks passed
@hikinggrass hikinggrass deleted the bugfix/evse-manager-switch-powersupply-phases branch November 12, 2024 11:11
hikinggrass pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants