SlacSimulator initialize state with UNMATCHED #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could publish an empty string on startup while an enum was expected, leading to failures when running EVerest with schema validation enabled remove default empty string from state_to_string enable -Werror=switch-enum for SlacSimulator module Signed-off-by: Kai-Uwe Hermann <[email protected]>
wku12
pushed a commit
to Qwello/everest-core
that referenced
this pull request
Nov 20, 2024
This could publish an empty string on startup while an enum was expected, leading to failures when running EVerest with schema validation enabled remove default empty string from state_to_string enable -Werror=switch-enum for SlacSimulator module Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
added a commit
that referenced
this pull request
Nov 21, 2024
This could publish an empty string on startup while an enum was expected, leading to failures when running EVerest with schema validation enabled remove default empty string from state_to_string enable -Werror=switch-enum for SlacSimulator module Signed-off-by: Kai-Uwe Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could publish an empty string on startup while an enum was expected, leading to failures when running EVerest with schema validation enabled
remove default empty string from state_to_string
enable -Werror=switch-enum for SlacSimulator module
Describe your changes
Issue ticket number and link
Checklist before requesting a review