Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error-framework: refactor usage of clear_error #239

Merged
merged 14 commits into from
Jan 31, 2025

Conversation

hikinggrass
Copy link
Contributor

No description provided.

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass hikinggrass changed the title Add missing ClearedByModule state error-framework: Add missing ClearedByModule state Jan 28, 2025
andistorm and others added 8 commits January 28, 2025 15:02
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass hikinggrass changed the title error-framework: Add missing ClearedByModule state error-framework: refactor usage of clear_error Jan 28, 2025
@hikinggrass hikinggrass requested a review from andistorm January 28, 2025 19:30
@hikinggrass
Copy link
Contributor Author

@andistorm I think your changes to this PR look good 🎇

Copy link
Contributor

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐧

everestjs/everestjs.cpp Show resolved Hide resolved
@hikinggrass hikinggrass merged commit 39ceadd into main Jan 31, 2025
5 checks passed
@hikinggrass hikinggrass deleted the bugfix/refactor-error-clear branch January 31, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants