Refactoring unit tests #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
force-pushed
the
feat/adding-test-bpt-control
branch
2 times, most recently
from
870e95a to
284082d
Compare
barsnick
reviewed
Jun 19, 2024
| template <typename DocType> | ||
| static EncodingResult encode(int (*encode_func)(exi_bitstream_t*, DocType*), const DocType& request, | ||
| const uint8_t* compare_data, std::size_t length) { | ||
| // FIXME (aw): what general size to take here? |
There was a problem hiding this comment.
Probably expand this as soon as we encounter larger streams.
There was a problem hiding this comment.
do the encode functions have a error code for "buffer too small"?
There was a problem hiding this comment.
do the encode functions have a error code for "buffer too small"?
Yes, EXI_ERROR__BITSTREAM_OVERFLOW.
SebaLukas
changed the title
SebaLukas
changed the title
barsnick
reviewed
Jun 21, 2024
barsnick
approved these changes
Jun 21, 2024
- Simplify tests & adding utility functions - Adding tests to test prober en- & decoding ISO20 bpt control mode - Fixing session setup res tests Signed-off-by: aw <[email protected]> Signed-off-by: Sebastian Lukas <[email protected]>
SebaLukas
force-pushed
the
feat/adding-test-bpt-control
branch
from
2ca3d2c to
c8bf469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
In order not to lose the manually fixed things through a newly generated code, these tests are introduced here.
Checklist before requesting a review