Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings - cbexigen hash: 90c70d0 #17

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ashesman
Copy link
Contributor

@ashesman ashesman commented Oct 21, 2024

Describe your changes

Re-generated files using latest cbexigen and copied changed files into libcbv2g.

Issue ticket number and link

#16

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@SebaLukas SebaLukas changed the title Imported changes from files generated by latest cbexigen. Fix compiler warnings - cbexigen hash: 90c70d0 Oct 22, 2024
Copy link
Collaborator

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good 👍
But I have one more request. Please update the hash in the CMakeLists.txt in line 19 to 90c70d0

@ashesman
Copy link
Contributor Author

Everything looks good 👍 But I have one more request. Please update the hash in the CMakeLists.txt in line 19 to 90c70d0

Done...

Copy link
Collaborator

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SebaLukas SebaLukas merged commit ee578a0 into EVerest:main Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants